Fix fatal AttributeError using Arrow 0.14.5 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidag
force-pushed
the
fix-deprecated-arrow-replace
branch
from
a37046c to
770c576
Compare
|
This PR should close issue #301 |
|
Related PR - arrow-py/arrow#624 |
jmaupetit
previously approved these changes
Aug 13, 2019
|
@davidag Can you update the changelog please? |
davidag
force-pushed
the
fix-deprecated-arrow-replace
branch
from
770c576 to
d13d3bf
Compare
|
@jmaupetit Done! |
davidag
force-pushed
the
fix-deprecated-arrow-replace
branch
from
d13d3bf to
d30dfef
Compare
|
Nice 👍 Now a fresh rebase and we will be good to go 😉 |
Since Arrow 0.14.5, Arrow.replace() has dropped shift functionality in favor of Arrow.shift(). This causes an AttributeError exception every time watson is run. The error message is: 'AttributeError: unknown attribute: "days"'
davidag
force-pushed
the
fix-deprecated-arrow-replace
branch
from
d30dfef to
f5bfc62
Compare
|
Ups. Fixed now! Thx 🎉 |
jmaupetit
approved these changes
Aug 20, 2019
This was referenced Aug 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Arrow 0.14.5,
Arrow.replace()has dropped shift functionality in favor ofArrow.shift(). The changelog states:This causes an
AttributeErrorexception every time watson is run.The error message is:
It can be reproduced just upgrading your Arrow package in your watson venv:
There are separate replace & shift functions since Arrow 0.9.0 and shifting using replace was marked deprecated since 0.7.1