Allow to force enable/disable colored output #350
Conversation
|
Thanks for this contribution @sienkiewiczkm 🙏 It seems hard to test... |
|
hi, any updates? @k4nar @jmaupetit I only searched for this in issues and found nothing. I've created #373 on my own, which I have closed when I discovered this PR. I would also like to see such option in Watson. |
|
LGTM. @k4nar WDYT? |
|
Whoops, I clicked "Update branch" by mistake (so merged Watson master to this commit). What's your usual workflow, should I rebase the change and wait for merge? |
|
This would be perfect to rebase your branch, and I'll merge it right after that! 🙏 |
My rebase+squash dismissed the review. I'm a bit new to GitHub pull requests, sorry about that! |
|
Arf, one more thing: can you fill the CHANGELOG please? 🙏 |
In most cases click library figures out correctly if colored output should be used, but sometimes it's wrong. For example when `watch` command is used click is unable to determine this and chooses uncolored output: `watch --color 'watson aggregate'` This change allows user to explicitly enable/disable coloring with --color and --no-color options: `watch --color 'watson --color aggregate'`
Done, I'm sorry that I'm very unresponsive lately. I hope that's not too inconvenient 😉 |
|
Don't be sorry to have a life @sienkiewiczkm 🙏 |
Added: - Log output order can now be controlled via the `--reverse/--no-reverse` flag and the `reverse_log` configuration option (#369) - Add `--at` flag to the `start` and `restart` commands (#364). - Add `--color` and `--no-color` flags to force output to be colored or not respectively (#350). Changed: - Require latest Arrow version 0.15.6 to support ISO week dates (#380) Fixed: - Make after-edit-check ensure that edited time stamps are not in the future (#381)
Added: - Log output order can now be controlled via the `--reverse/--no-reverse` flag and the `reverse_log` configuration option (#369) - Add `--at` flag to the `start` and `restart` commands (#364). - Add `--color` and `--no-color` flags to force output to be colored or not respectively (#350). Changed: - Require latest Arrow version 0.15.6 to support ISO week dates (#380) Fixed: - Make after-edit-check ensure that edited time stamps are not in the future (#381)
Hello!
In most cases click library figures out correctly if colored output should be used, but sometimes it's wrong. For example when
watchcommand is used click is unable to determine this and chooses uncolored output:This change allows user to explicitly enable/disable coloring with
--colorand--no-coloroptions:Related issue: pallets/click#1090