Modernize dj-database-url #151
Conversation
| checks: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 |
There was a problem hiding this comment.
There's a checkout@v2 of this action you might want to "check out".
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v1 |
There was a problem hiding this comment.
Similarly there's a setup-python@v2 as well.
| fail-fast: false | ||
| matrix: | ||
| django-version: [2.0, 2.1, 2.2, 3.0, 3.1, 3.2] |
| fail-fast: false | ||
| matrix: | ||
| django-version: [2.0, 2.1, 2.2, 3.0, 3.1, 3.2] | ||
| python-version: [3.6, 3.7, 3.8, 3.9] |
There was a problem hiding this comment.
Don't forget to wrap it with quotes "3.10", otherwise it is interpreted as float 3.1.
|
Thanks, we'll address these when we get the repository maintenance stuff squared away. |
|
Hi, just enquiring about the state of this PR. Keen to help out where I can because I've noticed a few more outdated items in the code that'd be good to get squared away. |
|
Now that we have the repository moved to its new home, I'll probably start merging and triaging this weekend. If you have specific fixes in mind that don't already have a PR or issue, by all means open up a new issue/PR. |
|
Cheers, very much appreciated. Can do. |
|
Is is possible to break this PR down into smaller chunks to make reviewing easier. My concern is this touches a lot of things and while i get it may add improvement, it is sweeping as a change. As this package is use by so many people I am worried new bugs or issues could be introduced on something which is fundimentally stable. |
|
A lot of the noise in this PR was from code formatting and CI updates. I can rework it without those since they're already done, and see how things look. |
I think this PR addresses a number of outstanding issues, namely:
configandparseAs I don't want to impose any more maintenance burden on you, consider this PR also as an offer to maintain this library. My original plan was to simply fork it and release under a new name, but figured it was worth offering. The current test suite is almost entirely unchanged (and passing - https://github.com/imsweb/django-dburl/actions/runs/1373144981) - it only drops pre-2.0 Django support, and registers the previously-supported backends:
https://github.com/imsweb/django-dburl/blob/modernize/test_dj_database_url.py#L12-L23
Happy to discuss further. I have a few projects at work that use this, so I'm invested in keeping it up to date, either by maintaining this library directly or maintaining my own fork under a new name.