Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo as a package to fix mypy issues #215

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

palfrey
Copy link
Member

@palfrey palfrey commented Apr 2, 2023

Fixes #214 by redoing things as a package.

https://github.com/jazzband/dj-database-url/actions/runs/4588415869/jobs/8102611523?pr=215 demos that the new test step reproduces the problem.

@palfrey palfrey changed the title Demo the mypy types issue Redo as a package to fix mypy issues Apr 2, 2023
@palfrey palfrey marked this pull request as ready for review April 2, 2023 11:25
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #215 (a46f64b) into master (2fbcdcb) will not change coverage.
The diff coverage is n/a.

❗ Current head a46f64b differs from pull request most recent head 1304bc6. Consider uploading reports for the commit 1304bc6 to get more accurate results

@@            Coverage Diff            @@
##            master      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           69        69           
  Branches        16        16           
=========================================
  Hits            69        69           
Impacted Files Coverage Δ
dj_database_url/__init__.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

setup.py Outdated Show resolved Hide resolved
@mattseymour mattseymour merged commit a7f94c8 into jazzband:master Apr 13, 2023
@palfrey palfrey deleted the package_folder branch April 13, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline types are not exposed to users
2 participants