Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config test options not unknown types #252

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

palfrey
Copy link
Member

@palfrey palfrey commented Sep 21, 2024

pyright in strict mode complains about the test options having an unknown type, which this fixes

/home/palfrey/src/sked/sked/settings.py:89:16 - error: Type of "config" is partially unknown
Type of "config" is "(env: str = DEFAULT_ENV, default: str | None = None, engine: str | None = None, conn_max_age: int | None = 0, conn_health_checks: bool = False, disable_server_side_cursors: bool = False, ssl_require: bool = False, test_options: Dict[Unknown, Unknown] | None = None) -> DBConfig" (reportUnknownMemberType)

This also explicitly adds pyright support to the CI to avoid this happening again

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5106a19) to head (1ac6257).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           76        76           
  Branches        18        18           
=========================================
  Hits            76        76           
Flag Coverage Δ
100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palfrey
Copy link
Member Author

palfrey commented Sep 28, 2024

Any thoughts @mattseymour ?

@palfrey palfrey merged commit 99128b5 into jazzband:master Oct 10, 2024
13 checks passed
@palfrey palfrey deleted the known-type-test-options branch October 10, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant