Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Django 4.1. #487

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Jul 11, 2022

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #487 (c13bb24) into master (807f98c) will decrease coverage by 0.16%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   83.33%   83.16%   -0.17%     
==========================================
  Files          16       16              
  Lines         594      594              
  Branches      118      118              
==========================================
- Hits          495      494       -1     
  Misses         66       66              
- Partials       33       34       +1     
Impacted Files Coverage Δ
constance/backends/database/__init__.py 58.69% <0.00%> (ø)
constance/apps.py 95.00% <75.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807f98c...c13bb24. Read the comment docs.

Comment on lines +25 to +30
if (
apps.is_installed('django.contrib.contenttypes') and
apps.is_installed('django.contrib.auth')
):
ContentType = apps.get_model('contenttypes.ContentType')
Permission = apps.get_model('auth.Permission')
Copy link
Member

@Mogost Mogost Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @felixxm for PR. It looks good but could you also look at #469 where this part of code was removed?
Your opinion may be significant.

@camilonova camilonova merged commit 7b59c64 into jazzband:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants