Add support for using gettext in fieldset headers #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 16 16
Lines 594 600 +6
Branches 118 120 +2
=======================================
+ Hits 495 500 +5
- Misses 66 67 +1
Partials 33 33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for #488
A simple fix that adds support for using a tuple instead of a dictionary for
CONSTANCE_CONFIG_FIELDSETS. This avoids the need to hash the fieldset header and therefore allows using thegettext_lazyfunction for them.Along the change itself, I've also included a test and an update to the documentation.