Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constance management command without admin installed #506

Conversation

syre
Copy link
Contributor

@syre syre commented Dec 1, 2022

Tried refactoring out ConstanceForm into forms.py and get_values into utils.py.

Fixes #498

@syre
Copy link
Contributor Author

syre commented Jan 2, 2023

Can anyone take a look at this?

@camilonova
Copy link
Member

Thank you. Let's find someone else who approves so we can merge it.

@syre
Copy link
Contributor Author

syre commented Jan 19, 2023

Are there any updates on this?

@syre
Copy link
Contributor Author

syre commented Jan 31, 2023

@camilonova

@syre
Copy link
Contributor Author

syre commented Feb 24, 2023

@Mogost @jezdez Is it possible for one of you to review as well so we can merge this?

@sergei-iurchenko
Copy link
Contributor

Merge develop, please, and fix issue. I think we can merge it

@syre syre force-pushed the fix-constance-management-command-without-admin-installed branch from e34dee6 to 2ee936d Compare March 30, 2023 21:03
@syre syre force-pushed the fix-constance-management-command-without-admin-installed branch from 2ee936d to cdf8f6d Compare March 30, 2023 21:13
@syre
Copy link
Contributor Author

syre commented Mar 30, 2023

@sergei-iurchenko can you have a look?

@camilonova camilonova merged commit 0047a78 into jazzband:master Apr 7, 2023
@syre syre deleted the fix-constance-management-command-without-admin-installed branch April 10, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constance CLI does not work properly without django admin
3 participants