Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migration on mysql #531

Conversation

sergei-iurchenko
Copy link
Contributor

@sergei-iurchenko sergei-iurchenko commented Oct 5, 2023

#528
Quoted is done correctly now.
I have tested on sqlite, mysql & postgresql

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #531 (1818915) into master (bc9707d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   90.21%   90.25%   +0.03%     
==========================================
  Files          31       31              
  Lines        1053     1057       +4     
  Branches      156      157       +1     
==========================================
+ Hits          950      954       +4     
  Misses         68       68              
  Partials       35       35              
Files Coverage Δ
...onstance/migrations/0002_migrate_from_old_table.py 86.36% <100.00%> (+3.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergei-iurchenko
Copy link
Contributor Author

@camilonova review please

@camilonova camilonova merged commit d03bea8 into jazzband:master Oct 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants