Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better already migrated detection #588

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented Sep 16, 2024

@ivan-klass could you review this, please?
Fix #585. Related #578

@Mogost Mogost self-assigned this Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.96%. Comparing base (ef24fcb) to head (dd24cce).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
constance/migrations/0003_drop_pickle.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
- Coverage   89.92%   83.96%   -5.96%     
==========================================
  Files          31       21      -10     
  Lines        1032      736     -296     
  Branches      104      132      +28     
==========================================
- Hits          928      618     -310     
- Misses         69       82      +13     
- Partials       35       36       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mogost Mogost force-pushed the better-already-migrated-detection branch from d972726 to 8f9f884 Compare September 17, 2024 09:42
@Mogost Mogost force-pushed the better-already-migrated-detection branch from 8f9f884 to dd24cce Compare September 17, 2024 09:51
@Mogost Mogost merged commit d624ee8 into jazzband:master Sep 17, 2024
9 of 11 checks passed
@Mogost Mogost deleted the better-already-migrated-detection branch September 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_pickle.UnpicklingError after failed migration
2 participants