Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RP Initiated Logout when no user is found #1284

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix RP Initiated Logout when no user is found #1284

merged 1 commit into from
Jun 12, 2023

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Jun 12, 2023

Fixes #1280

Description of the Change

Don't crash when we only have a AnonymousUser to logout (no id_token_hint or existing session),

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@tonial tonial requested a review from a team June 12, 2023 08:26
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1284 (e5e0ff0) into master (2f3dd45) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head e5e0ff0 differs from pull request most recent head 1c44a29. Consider uploading reports for the commit 1c44a29 to get more accurate results

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   97.30%   97.25%   -0.05%     
==========================================
  Files          32       32              
  Lines        2003     2005       +2     
==========================================
+ Hits         1949     1950       +1     
- Misses         54       55       +1     
Impacted Files Coverage Δ
oauth2_provider/views/oidc.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@n2ygk n2ygk merged commit f28ca84 into jazzband:master Jun 12, 2023
@tonial tonial deleted the alaurent/fix_logout_500 branch June 13, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route "/o/logout" returns 500 Internal Server Error
2 participants