Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst requirements #1375

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

suspiciousRaccoon
Copy link
Contributor

I simply copy pasted the ones from the README.rst

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

suspiciousRaccoon and others added 2 commits December 18, 2023 15:17
I simply copy pasted the ones from the README.rst
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4a4d4d) 97.56% compared to head (0d52436) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          32       32           
  Lines        2132     2132           
=======================================
  Hits         2080     2080           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. It would be DRYer if we were able to have one file listing these requirements and include it in the markdown, RST, and setup.cfg but that appears to be not something that can easily be done.

@n2ygk n2ygk merged commit 25c6304 into jazzband:master Dec 18, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants