Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Django versions below 4.2 #1455

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 14, 2024

Description of the Change

Django versions below 4.2 are no longer supported, so this PR removes mentions and CI for these versions.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@dulmandakh dulmandakh changed the title drop support for Django below 4.2 drop support for Django versions below 4.2 Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (51d9798) to head (75c28f8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
- Coverage   97.34%   97.32%   -0.03%     
==========================================
  Files          32       32              
  Lines        2112     2128      +16     
==========================================
+ Hits         2056     2071      +15     
- Misses         56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulmandakh
Copy link
Contributor Author

@n2ygk please review and merge. I have no idea why codecov is failing. Let's make CI lean and clean.

@n2ygk
Copy link
Member

n2ygk commented Aug 14, 2024

Yeah codecov keeps misreporting that tiny delta but it's unclear why. Luckily it done's block accepting the PR.

@n2ygk n2ygk force-pushed the remove-django-below-4.2 branch from 75c28f8 to 2e2af76 Compare August 14, 2024 17:47
@n2ygk n2ygk self-requested a review August 14, 2024 17:50
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for simplifying the workfliws.

One question regarding python 3.8, 3.9 needs to be resolved.

.github/workflows/test.yml Show resolved Hide resolved
@n2ygk n2ygk merged commit 7e13413 into jazzband:master Aug 15, 2024
19 checks passed
@dulmandakh dulmandakh deleted the remove-django-below-4.2 branch August 15, 2024 14:10
@n2ygk n2ygk added this to the 3.0.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants