Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest to <7 #691

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Pin pytest to <7 #691

merged 1 commit into from
Nov 1, 2023

Conversation

foarsitter
Copy link
Contributor

@foarsitter foarsitter commented Nov 1, 2023

This PR pins pytest to < 7.0 to mitigate #690

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #691 (ad9ab64) into master (e562b5c) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #691     +/-   ##
========================================
- Coverage    60.5%   60.5%   -0.0%     
========================================
  Files          41      41             
  Lines        2605    2605             
  Branches       69      69             
========================================
- Hits         1575    1574      -1     
- Misses       1017    1018      +1     
  Partials       13      13             
Flag Coverage Δ
mypy 35.1% <ø> (-<0.1%) ⬇️
tests 89.8% <ø> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

you got me! I was just about opening a PR myself! 😄

@WisdomPill WisdomPill merged commit b6ea4b4 into jazzband:master Nov 1, 2023
26 of 28 checks passed
@foarsitter
Copy link
Contributor Author

@WisdomPill dammit, that would have saved me a lot of trouble!

As always, thanks for your quick response!

@foarsitter foarsitter deleted the pytest6 branch November 1, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants