Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Expire method fails when using DEFAULT_TIMEOUT #726

Merged
merged 7 commits into from
Feb 17, 2024
Merged

Fix:Expire method fails when using DEFAULT_TIMEOUT #726

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b775d0c
Fix:Expire method fails when using DEFAULT_TIMEOUT #724
Feb 16, 2024
f391938
Testcase and changelog added for issue #724
Feb 16, 2024
740520a
Changelog file renamed
Feb 16, 2024
9a38b1c
Fix:mypy errors
Feb 16, 2024
6285275
Fix for DEFAULT_TIMEOUT for pexpire, unwanted comments removed and te…
Feb 16, 2024
23b1b68
Improvement: None removed for timeout
Feb 17, 2024
8bf4390
Improvement: None removed for timeout
Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions django_redis/client/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@
version: Optional[int] = None,
client: Optional[Redis] = None,
) -> bool:
if timeout is DEFAULT_TIMEOUT:
timeout = self._backend.default_timeout

Check warning on line 303 in django_redis/client/default.py

View check run for this annotation

Codecov / codecov/patch

django_redis/client/default.py#L303 

Added line #L303 was not covered by tests

if client is None:
client = self.get_client(write=True)

Expand Down
Loading