Remove legacy code from Python 2 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotzbua
force-pushed
the
remove_legacy_py2
branch
from
169e31a to
6f0c7a9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #294 +/- ##
===========================================
+ Coverage 90.30% 91.47% +1.17%
===========================================
Files 9 9
Lines 227 223 -4
Branches 35 35
===========================================
- Hits 205 204 -1
+ Misses 19 16 -3
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@giovannicimolin This also looks good to me. Let me know what you think. |
giovannicimolin
approved these changes
Oct 10, 2023
dontexit
pushed a commit
to dontexit/django-rest-knox
that referenced
this pull request
Jan 24, 2024
Remove legacy code from Python 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not needed with Python 3 because it is default lib.