Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): possible path bug #348

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented May 16, 2024

Double quote to prevent globbing and word splitting. https://github.com/koalaman/shellcheck/wiki/SC2046

@Rotzbua Rotzbua changed the title fix possible path bug fix(docker): possible path bug May 16, 2024
@giovannicimolin
Copy link
Contributor

@Rotzbua Thanks for the contribution. I'm queuing this up for review next week.

Double quote to prevent globbing and word splitting.
https://github.com/koalaman/shellcheck/wiki/SC2046
@Rotzbua Rotzbua force-pushed the fix_docker_script branch from f9ba73c to e34638e Compare June 22, 2024 16:55
Copy link
Contributor

@giovannicimolin giovannicimolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good!

@giovannicimolin giovannicimolin merged commit aea0205 into jazzband:develop Jul 22, 2024
8 checks passed
@Rotzbua Rotzbua deleted the fix_docker_script branch July 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants