Remove admin/js/jquery.init.js from SortedCheckboxSelectMultiple
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jquery.init.js` seems to be used by Django's admin templates to remap `$` into `django.jQuery`, and then _remove `$` from the global scope_. Its contents are:
```
var django=django||{};django.jQuery=jQuery.noConflict(true);
```
(See https://api.jquery.com/jQuery.noConflict/.) This means that including a `SortedCheckboxSelectMultiple` widget on a page that expects jQuery to be accessible under `$` breaks code on that page.
This commit removes the loading of `jquery.init.js`, which fixes this issue. The existing code does not appear to be relying on its behaviour, and it was introduced recently in 19a11c9 (without explicit justification that I could find).
Xyene
added a commit
to DMOJ/online-judge
that referenced
this pull request
Oct 26, 2019
A PR has been opened upstream at jazzband/django-sortedm2m#149, but seems unacknowledged at the moment.
|
Just wanted to confirm that the removed JS does not seem to be necessary even on 2.2 (to which we have upgraded), and that the CI failure seem to be unrelated to this change. |
auvipy
approved these changes
Mar 5, 2020
This was referenced Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jquery.init.jsseems to be used by Django's admin templates to remap$intodjango.jQuery, and then remove$from the global scope. Its contents are:(See https://api.jquery.com/jQuery.noConflict/.) This means that including a
SortedCheckboxSelectMultiplewidget on a page that expects jQuery to be accessible under$breaks code on that page.This commit removes the loading of
jquery.init.js, which fixes this issue. The existing code does not appear to be relying on its behaviour, and it was introduced recently in 19a11c9 (without explicit justification that I could find).