Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding django3.2 in tox. #184

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Jul 8, 2021

Adding django3.2 in tox.
Fixing warnings.

Fixing warnings.
@awais786 awais786 marked this pull request as ready for review July 15, 2021 17:10
@richardbarran
Copy link
Contributor

Hi - a suggestion: Django 3.0 is no longer supported. Can you update the PR to remove testing of that version?

@clintonb
Copy link
Contributor

clintonb commented Aug 1, 2021

@richardbarran deprecation should happen in a separate commit and new major version.

@awais786 sorry I missed this.

@clintonb clintonb merged commit f6a7e6d into jazzband:master Aug 1, 2021
@richardbarran
Copy link
Contributor

@clintonb ok.
Do you have the permissions/authority to make a new release of this package? It would be nice to have a new version with "works with Django 3.2" in the changelog.

@clintonb
Copy link
Contributor

clintonb commented Aug 1, 2021

@richardbarran yep. I can work on that later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants