Fix error in field in Django 5.1 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ManyToManyRel.is_hidden()` has been removed in Django 5.1, leaving `ManyToManyRel.hidden`. This resulted in a fatal error when using django-sortedm2m in Django 5.1 where `is_hidden()` is used in `sortedm2m/fields.py`. This commit replaces that call with use of the `hidden` property. For jazzband#214
clintonb
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManyToManyRel.is_hidden()has been removed in Django 5.1, leavingManyToManyRel.hidden. This resulted in a fatal error when using django-sortedm2m in Django 5.1 whereis_hidden()is used insortedm2m/fields.py.This commit replaces that call with use of the
hiddenproperty.I haven't been able to run the tests on this. I've given the
test_projecta quick go with both Django 4.2 and 5.1 and it successfully starts up, which it didn't before the change.For #214