Fixed performance when there is a lot of item in the m2m relation and a visual glitch. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visual glitch. Formerly the jQuery code was looping through all the potential <input> elements that could be added to the m2m relationship in order to find the parent <ul> elements. It is now done this other way around, we only loop through <ul> elements that have <input> child with the `sortedm2m` class. We are also hidding the <ul> until it gets fully prepared, to avoid to have a bad flicker when initially loading the page.
|
ping @gregmuellegger :-) |
| <div class="sortedm2m-container"> | ||
|
|
||
| <p class="selector-filter"> | ||
| <img src="{% static "sortedm2m/selector-search.gif" %}" alt="" title="{% trans "Type into this box to filter down the list." %}" /> | ||
| <input type="text" placeholder="{% trans "Filter" %}" /> | ||
| </p> | ||
|
|
||
| <ul> | ||
| <ul class="hide"> |
There was a problem hiding this comment.
Could we make the hide class be added by JS on load? The problem here I see is if you don't have JS enabled you will never see the checkboxes ... I'm not sure if I'm living in the 1990s in that regard, what do you think?
|
Hey, that's a super cool addition. Thanks for taking the time! I will merge it as soon as I know your opinion on the inline comment I made ;) |
|
I don't believe anybody will hit django's admin interface without js enabled nowadays but well, it's always better to be safe so I applied what you asked for ;-) |
johnraz
force-pushed
the
fix-perf-and-glitch
branch
from
ae86d6e
to
abda401
Compare
gregmuellegger
added a commit
that referenced
this pull request
Jun 18, 2015
|
Awesome! Merged and released in 1.0.1 https://pypi.python.org/pypi/django-sortedm2m/1.0.1 |
|
Sweet! thanks for the release ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly the jQuery code was looping through all the potential
<input>elementsthat could be added to the m2m relationship in order to find the parent
<ul>elements. It is now done this other way around, we only loopthrough
<ul>elements that have<input>child with thesortedm2mclass.
(With this change a page that would take 12sec to load before is now loading instantly.)
We are also hidding the
<ul>until it gets fully prepared, to avoid to havea bad flicker when initially loading the page.