Update to support Django 1.9 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 1.9 removes ReverseManyRelatedObjectsDescriptor in favor of using ManyRelatedObjectsDescriptor with `reverse` argument passed into it (though the meaning of reverse has been reversed, hah). It also adds a set() method to RelatedManager that handles setting all the new related objects. It tries to be more efficient by only adding and removing the ones necessary instead of clearing them all and adding them again. The old behavior is maintained by passing the `clear` keyword argument, which is what we now do.
| return create_sorted_many_related_manager( | ||
| self.rel.model._default_manager.__class__, | ||
| self.rel, | ||
| False # This is the new `reverse` argument (which ironically should be False) |
There was a problem hiding this comment.
Could we use keyword arguments here, so that it's clear (even without the comment) what the arguments stand for?
There was a problem hiding this comment.
Considered it, but thought it would be a bit dirtier because passing that up to Django's create_many_related_manager would require some more manipulation inside our create_sorted_many_related_manager function since it's a new argument they added in 1.9. They didn't make it a keyword argument, so I figured since our function really just wraps theirs, that we should treat it the same.
|
Awesome PR, thanks! I'll get this merged after you get back on the inline comment 👍 good work! |
gregmuellegger
added a commit
that referenced
this pull request
Aug 13, 2015
|
Meeeeerged :) A big cheers for the good work! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.9 removes ReverseManyRelatedObjectsDescriptor in favor of using ManyRelatedObjectsDescriptor with
reverseargument passed into it (though the meaning of reverse has been reversed, hah).It also adds a set() method to RelatedManager that handles setting all the new related objects. It tries to be more efficient by only adding and removing the ones necessary instead of clearing them all and adding them again. The old behavior is maintained by passing the
clearkeyword argument, which is what we now do.