Use different function name for dismissing "add" popup when necessary #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 1.8 introduced a change of the function name from `dismissAddAnotherPopup` to `dismissAddRelatedObjectPopup`. Old name was kept for backwards compatibility, but since it's value is now a reference and not an actual function, sortedm2m overrides only that reference and not the actual `dismissAddRelatedObjectPopup` which is now the function being called in `django/contrib/admin/templates/admin/popup_response.html`. Since django no longer calls the overridden function, the added object would only appear after refresh. Ref: django/django@0798874#diff-ec17958cc9f7c2542303557dfc4ad997R130
|
Cool! Good catch. Thanks for your efforts. |
gregmuellegger
added a commit
that referenced
this pull request
Apr 21, 2016
|
Thank you! |
|
Released a new version containing the fix: https://pypi.python.org/pypi/django-sortedm2m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.8 introduced a change of the function name from
dismissAddAnotherPopuptodismissAddRelatedObjectPopup. Old name waskept for backwards compatibility, but since it's value is now a
reference and not an actual function, sortedm2m overrides only that
reference and not the actual
dismissAddRelatedObjectPopupwhich isnow the function being called in
django/contrib/admin/templates/admin/popup_response.html. Since djangono longer calls the overridden function, the added object would only
appear after refresh.
This pull request makes it compatible with django 1.8+.
Ref: django/django@0798874#diff-ec17958cc9f7c2542303557dfc4ad997R130