build input for fields that don't have any checkboxes yet #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously only the lists that already had checkboxes were initialized, so the "Add related" popup was throwing errors and weren't showing anything before refresh. Now if checkboxes do not exist yet, the id / name will be derived from the nearest label
|
👍 |
if jQuery was actually undefined it was throwing a reference error
|
Hi @gregmuellegger, any chance you could check this PR out if you have time? |
gregmuellegger
added a commit
that referenced
this pull request
Jun 27, 2016
|
That's part of the 1.3.1 release. Thanks for taking the effort and the friendly reminder :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously only the lists that already had checkboxes were
initialized, so the "Add related" popup was throwing errors and
weren't showing anything before refresh. Now if checkboxes do not
exist yet, the id / name will be derived from the nearest label
essentially this fixes #57