-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More templatetags #165
Merged
Merged
More templatetags #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 91.82% 92.62% +0.79%
==========================================
Files 16 16
Lines 673 746 +73
Branches 48 50 +2
==========================================
+ Hits 618 691 +73
Misses 45 45
Partials 10 10
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WhyNotHugo
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No obvious issues here.
WhyNotHugo
reviewed
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement #133.
Description
Add the
platform
andbrowser
template tags, and utilize them within thedevice
template tag.Motivation and Context
This makes it easier to separate pieces of a user agent when displaying to a user.
Closes #133.
How Has This Been Tested?
Added tests for each new template tag. The data for the tests is the same data as for the
device
tag, since it uses the same data.I completely decoupled the three test cases (
PlatformTemplateFilterTest
,BrowserTemplateFilterTest
, andDeviceTemplateFilterTest
) since I didn't want changes to one to affect the other.Screenshots (if appropriate):
Types of changes
Checklist:
and existingtests passed.