Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff #173

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Use ruff #173

merged 3 commits into from
Oct 16, 2023

Conversation

blag
Copy link
Contributor

@blag blag commented Oct 11, 2023

Closes #168.

Description

Use ruff instead of isort, flake8, and pyupgrade. Ruff replaces those, including the flake8 plugins that were previously used.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #173 (11a6917) into master (5ab2c57) will increase coverage by 0.17%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   94.92%   95.10%   +0.17%     
==========================================
  Files          16       16              
  Lines         768      796      +28     
  Branches       65       68       +3     
==========================================
+ Hits          729      757      +28     
- Misses         29       30       +1     
+ Partials       10        9       -1     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also delete setup.cfg. Makefile and tox.ini still refer to flake8.

@blag
Copy link
Contributor Author

blag commented Oct 16, 2023

Good catch, thanks! Fixed.

Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhyNotHugo WhyNotHugo merged commit 6ccc1a0 into master Oct 16, 2023
39 checks passed
@WhyNotHugo WhyNotHugo deleted the use-ruff branch October 16, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize ruff
2 participants