-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate hashes for all available candidates #1723
Generate hashes for all available candidates #1723
Conversation
652f574
to
663100c
Compare
6cd6261
to
fbeae56
Compare
99ad0d2
to
3539891
Compare
@atugushev wdyt about the current test coverage? |
That's because it's been installed from sdists from PyPI (note "Downloading torch_scatter-2.0.9.tar.gz"), which has import torch in setup.py. Note, there are no wheels for Python 3.11 in https://data.pyg.org/whl/torch-1.13.0+cpu.html. With others Python version works fine, because they've been installed from wheels from https://data.pyg.org/whl/torch-1.13.0+cpu.html |
Generate hashes covering the PyPi index as well as additional candidates available through an extra index of find-links. Currently if PyPi index is available the hashes will be limited to those available in it. [#pre-commit.ci] auto fixes from pre-commit.com hooks [#pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
0107f68
to
b649d0a
Compare
That's looking better, thanks for the help on the test side @atugushev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🎉 A few comments about docstrings:
b649d0a
to
b01d481
Compare
Generate hashes covering the PyPi index as well as additional candidates available through an extra index of find-links. Currently if PyPi index is available the hashes will be limited to those available in it.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.Fixes #1662