Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly quote edit command on Windows #1279

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

quintesse
Copy link
Contributor

Fixes #1068

Was a good beginner issue but it was already open for too long :-)

@quintesse quintesse requested a review from maxandersen March 7, 2022 18:59
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1279 (1d5d9a2) into main (238ef90) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1279      +/-   ##
============================================
- Coverage     58.75%   58.73%   -0.02%     
  Complexity     1126     1126              
============================================
  Files            96       96              
  Lines          5962     5964       +2     
  Branches        991      991              
============================================
  Hits           3503     3503              
- Misses         1955     1957       +2     
  Partials        504      504              
Flag Coverage Δ
Linux 57.49% <0.00%> (-0.02%) ⬇️
Windows 57.54% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/jbang/cli/Edit.java 46.55% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238ef90...1d5d9a2. Read the comment docs.

@maxandersen maxandersen merged commit 056ca3b into jbangdev:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jbang edit fails in PowerShell
2 participants