Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed problem with additional sources and aliases #1284

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

quintesse
Copy link
Contributor

No description provided.

@quintesse quintesse requested a review from maxandersen March 9, 2022 22:08
@quintesse quintesse force-pushed the aliased_sources_fix branch from 1db4ff6 to ed55bf2 Compare March 9, 2022 22:12
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1284 (ed55bf2) into main (b9c4b1b) will increase coverage by 0.09%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1284      +/-   ##
============================================
+ Coverage     59.05%   59.15%   +0.09%     
- Complexity     1141     1154      +13     
============================================
  Files            97       97              
  Lines          6008     6020      +12     
  Branches        997      998       +1     
============================================
+ Hits           3548     3561      +13     
+ Misses         1952     1951       -1     
  Partials        508      508              
Flag Coverage Δ
Linux 57.92% <36.36%> (+0.10%) ⬆️
Windows 57.97% <36.36%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/dev/jbang/catalog/ImplicitCatalogRef.java 56.00% <17.64%> (-3.53%) ⬇️
src/main/java/dev/jbang/source/RunContext.java 90.76% <100.00%> (+0.19%) ⬆️
.../java/dev/jbang/dependencies/ModularClassPath.java 85.71% <0.00%> (+1.42%) ⬆️
src/main/java/dev/jbang/catalog/Catalog.java 72.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d7a27...ed55bf2. Read the comment docs.

@maxandersen maxandersen merged commit 2dceffb into jbangdev:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants