Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore dependencies without GVA for integration #1350

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

maxandersen
Copy link
Collaborator

if you use --class-path xyz.jar no GVA is present which currently makes integration calls fail.

This fixes it so NPE does not occur; but long term we should find a way to include classpath for integration calls.

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #1350 (f506dd1) into main (e7391c1) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##               main    #1350   +/-   ##
=========================================
  Coverage     56.52%   56.53%           
  Complexity     1165     1165           
=========================================
  Files           100      100           
  Lines          6172     6173    +1     
  Branches       1020     1021    +1     
=========================================
+ Hits           3489     3490    +1     
+ Misses         2203     2202    -1     
- Partials        480      481    +1     
Flag Coverage Δ
Linux 55.27% <50.00%> (-0.08%) ⬇️
Windows 55.95% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/java/dev/jbang/spi/IntegrationManager.java 18.00% <50.00%> (-0.13%) ⬇️
src/main/java/dev/jbang/util/JavaUtil.java 42.85% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7391c1...f506dd1. Read the comment docs.

@maxandersen maxandersen merged commit 5c8094c into jbangdev:main Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant