fix: make integrations work again #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quintesse
commented
Dec 20, 2022
•
quintesse
commented
- properly passing tags to the integrations again
- fixed that the integrations were running externally in too many cases where the current JVM was matching but wasn't used.
- passing properties to external integrations
The integrations were running externally in too many cases where the current JVM was matching but wasn't used.
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 110 110
Lines 6973 6976 +3
Branches 1139 1140 +1
=====================================
- Misses 6973 6976 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Becuase of the new way of handling tags in source files where we strip off the leading `//` the integrations that expected those slashes now started failing. We now prepend slashes to all tags before passing them on to the integrations to remain backward compatible. Fixes jbangdev#1526
quintesse
changed the title
quintesse
force-pushed
the
fix_qintegration
branch
from
4cc0561 to
4ed8074
Compare
maxandersen
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.