fix: we don't blindly import JAR metadata anymore #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a way to skip importing metadata into a Project if a JAR was available locally, but that was still causing problems in certain situations. For example if you would compile with Java 19 and then uninstall Java 19 leaving an earlier version, let's say Java 11, jbang would try to download Java 19 just to run the code, even though nothing in the source indicated that was necessary. In that case it's much more convenient to simply recompile the code with Java 11. The solution now is to not import the metadata into the Project anymore, but to make it an explicit action of reading the information and let the code that does the reading decide what to do with it.
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 121 121
Lines 7377 7376 -1
Branches 1199 1199
=====================================
+ Misses 7377 7376 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a way to skip importing metadata into a Project if a JAR was available locally, but that was still causing problems in certain situations. For example if you would compile with Java 19 and then uninstall Java 19 leaving an earlier version, let's say Java 11, jbang would try to download Java 19 just to run the code, even though nothing in the source indicated that was necessary. In that case it's much more convenient to simply recompile the code with Java 11. The solution now is to not import the metadata into the Project anymore, but to make it an explicit action of reading the information and let the code that does the reading decide what to do with it.