Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in edit message #1722

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: typo in edit message #1722

merged 2 commits into from
Feb 9, 2024

Conversation

tarilabs
Copy link
Contributor

@tarilabs tarilabs commented Jan 1, 2024

Hi 👋 Happy New 2024!

I've just created a new script with jbang init -t cli scripts/process_entries.java

And I get as output:

[jbang] File initialized. You can now run it with 'jbang scripts/process_entries.java' or edit it using 'jbang edit --open=[editor] scripts/process_entries.java' where [editor] is your editor or IDE, e.g. 'code'. If your IDE supports JBang, you can edit the directory instead: 'jbang edit . 'scripts/process_entries.java. See https://jbang.dev/ide

The part about the directory is unclear to me and I believe there is a typo, which should read instead:

If your IDE supports JBang, you can edit the directory instead: 'jbang edit . '. 

(without the name of the script repeated outside of the single quote command).

Hope this helps?
Sorry if the message was intentional, but in that case I didn't understood it 🤔

@maxandersen maxandersen changed the title Fix typo in edit message fix: typo in edit message Jan 2, 2024
@maxandersen
Copy link
Collaborator

The intent is you tell the IDE to run against the directory you are in and opens the source file.

otherwise you need to manually open the file afterwards.

@tarilabs
Copy link
Contributor Author

tarilabs commented Jan 2, 2024

The intent is you tell the IDE to run against the directory you are in and opens the source file.
otherwise you need to manually open the file afterwards.

thanks for the feedback!

if so the command 'jbang edit . 'scripts/process_entries.java did not work?
is the renderedScriptOrFile meant to be placed inside the quote then? 🤔
or which command should actually be evaluated on shell, please?

@maxandersen
Copy link
Collaborator

if so the command 'jbang edit . 'scripts/process_entries.java did not work? is the renderedScriptOrFile meant to be placed inside the quote then? 🤔 or which command should actually be evaluated on shell, please?

not sure if you meant that exact command - the quote is wrong.

it should be: jbang edit . scripts/process_entries.java

@tarilabs
Copy link
Contributor Author

tarilabs commented Feb 3, 2024

it should be: jbang edit . scripts/process_entries.java

df2a589 would display:

... instead: 'jbang edit . scripts/process_entries.java'.

which I understand is what the user should highlight and copy away in the terminal.

As of today the displayed actually is:

... instead: 'jbang edit . 'scripts/process_entries.java.

The end single quote was before the script file so the user would stop highlighting and copying before it?

@maxandersen maxandersen merged commit bd0c49a into jbangdev:main Feb 9, 2024
1 check passed
@maxandersen
Copy link
Collaborator

@all-contributors please add @tarilabs for bugfix

Thanks!

Copy link
Contributor

@maxandersen

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@maxandersen
Copy link
Collaborator

https://github.com/all-contributors please add @tarilabs for code

@tarilabs
Copy link
Contributor Author

tarilabs commented Feb 9, 2024

@all-contributors please add @tarilabs for code

I believe didn't pick last message above^

Copy link
Contributor

@tarilabs

I've put up a pull request to add @tarilabs! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants