-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 'app list' only return executables #1783
Conversation
Do I need to change the commit name? If required I'll do that |
If you could, that would be awesome :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a simple and possibly useful enough change.
Btw, what is your specific use-case that you need this fix? Theoretically there shouldn't be any non-executable files in that directory, right? |
50a0dc5
to
d8e3c8c
Compare
Theoretically, yes. But in practice any random file will show up, like macOS .DS_Store files (that's how I stumbled on this). Also I could see someone pointing this directory to a different, 'unclean' one where also any file would be seen in the output |
Btw, for future improvement we should probably change this to use |
TIL, I wasn't aware of this distinction |
Yeah, I should have mentioned it, but I forgot. No worries. Things is that on Windows |
Currently
jbang app list
prints out all the files in the bin directory. This PR fixes this by filtering the files by the executable flag (scripts in PATH are picked up by the shell only if they're executable anyways)