feat: Improve error message to know where to place --verbose option #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes jbangdev#1864 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
commented
Nov 15, 2024
| @@ -467,7 +467,7 @@ static public void errorMsg(String msg, Throwable e) { | |||
| if (msg != null) { | |||
| infoMsg(e.getMessage()); | |||
| } | |||
| infoMsg("Run with --verbose for more details"); | |||
| infoMsg("Run with --verbose for more details. The --verbose must be placed before the jbang command. I.e. jbang --verbose run [...]"); | |||
There was a problem hiding this comment.
Is it always before the jbang command or it can also be placed after the jbang command as a parameter of it?
There was a problem hiding this comment.
It can be placed anywhere before the source or GAV or alias. Since anything after that gets used as argument to the launched app.
These are equal:
jbang --verbose app.java
jbang run --verbose app.java
jbang --verbose app.java
but here --verbose is passed to app.java not to jbang:
jbang app.java --verbose
There was a problem hiding this comment.
Just to be more explicit, you can basically put it anywhere, except for the run , alias add and app install commands where you can't put at after the main argument because in those 3 cases it would be considered a user parameter, as Max explained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1864