use docker/spdystream again #9
Conversation
|
Note: travis tests broken. run |
|
and these tests pass with your version of spdystream? |
|
Yeah :/, but the version I have is broken too, as we discovered after testing it. |
|
we should try out https://github.com/SlyMarbo/spdy . maybe it doesnt have the bug we're seeing here? @SlyMarbo, any comparisons between your lib and dockers spdystream? |
|
I haven't done any comparison myself and I'm not familiar with Docker's package. I have no reason to believe you should have any issues with my package, but I'd recommend moving on to HTTP/2 if that's an alternative, since SPDY is being deprecated by a lot of people. https://github.com/bradfitz/http2 would be a great place to start, but if you're committed to SPDY give my package a go :) |
|
@SlyMarbo thanks for the response! we'll be moving to http2 soon, we're only using spdy because we can interop with node easier that way (no streams based http2 impl in node yet) |
|
that may not have fixed it... |
|
yeah... so that didnt fix it.. it just removed the deadlock. now i'm getting EOF's all over. |
whyrusleeping
force-pushed
the
docker/spdystream
branch
from
a97498f
to
9fd42bb
Compare
jbenet
force-pushed
the
docker/spdystream
branch
from
9505b64
to
e821dad
Compare
|
@whyrusleeping fixed it! :) see: jbenet/spdystream@f8ff317 What doesn't make me feel great is that i can seemingly deadlock spdystream: jbenet/spdystream@sync-stream-creation-test though not sure if I'm doing something stupid |
|
Thats... concerning. You gonna PR against docker? |
spdystream has been updated since i last messed with it.
commit log promises important race fixes.
So this PR uses docker/spdystream again, without my fixes.
(it seems they handled what i fixed differently).
But this doesn't pass the peerstream tests :/ it deadlocks. not sure
if its on our side or spdystream's. (i suspect spdystream)