Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemblies saved with DeterministicMvid and portable pdbs cannot be loaded #583

Closed
mrvoorhe opened this issue May 29, 2019 · 2 comments
Closed

Comments

@mrvoorhe
Copy link
Contributor

I was using DeterministicMvid in monolinker and had an assembly with portablepdbs. monolinker was able to strip and write the assembly without issue. However, if anything tries to read that assembly back in ModuleDefinition.ReadSymbols() throws a SymbolsNotMatchingException exception. See #582 for more details.

mrvoorhe added a commit to Unity-Technologies/linker that referenced this issue May 30, 2019
The test for mdb + deterministic mvid and portable pdb + deterministic mvid had to be ignored because they encounter jbevain/cecil#583
@mrvoorhe
Copy link
Contributor Author

Here is a PR to monolinker where I add tests that can reproduce this bug and #582

dotnet/linker#591

The tests that had to ignored were
https://github.com/mono/linker/pull/591/files#diff-9e1723272bec2ea79732459e86209708
https://github.com/mono/linker/pull/591/files#diff-69dc58f47a0fd2c82f2c55326cae2177

If you wanted to run the tests remove the [IgnoreTestCase ("Requires cecil updated with fix for https://github.com/jbevain/cecil/issues/583")]

marek-safar pushed a commit to dotnet/linker that referenced this issue May 30, 2019
The test for mdb + deterministic mvid and portable pdb + deterministic mvid had to be ignored because they encounter jbevain/cecil#583
vargaz added a commit to vargaz/cecil that referenced this issue May 30, 2019
…eds the guid of the corresponding assembly.

Fixes jbevain#583.
@jbevain
Copy link
Owner

jbevain commented May 31, 2019

Fixed by #587.

@jbevain jbevain closed this as completed May 31, 2019
mrvoorhe added a commit to Unity-Technologies/linker that referenced this issue Jun 4, 2019
The test for mdb + deterministic mvid and portable pdb + deterministic mvid had to be ignored because they encounter jbevain/cecil#583
tkapin pushed a commit to tkapin/runtime that referenced this issue Jan 31, 2023
The test for mdb + deterministic mvid and portable pdb + deterministic mvid had to be ignored because they encounter jbevain/cecil#583

Commit migrated from dotnet/linker@d24b2e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants