Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add strong key pair for NET Standard #650

Closed
wants to merge 3 commits into from
Closed

add strong key pair for NET Standard #650

wants to merge 3 commits into from

Conversation

jetersen
Copy link

Hi @SimonCropp and @jbevain I followed up on the suggestion in #548

Not sure if my 54a8987 is helpful, I can easily remove it if you feel like it's a bad addition.

For our use case it meant we could remove using System.Reflection and avoid the same

#if (NETSTANDARD)
using StrongNameKeyPair=Mono.Cecil.StrongNameKeyPair;
#else
using StrongNameKeyPair=System.Reflection.StrongNameKeyPair;
#endif

In all our files that used StrongNameKeyPair.

SimonCropp and others added 3 commits February 15, 2020 07:52
On NETFramework target Mono.Cecil's StrongNameKeyPair should extend System.Reflection.StrongNameKeyPair for ease of use when using Mono.Cecil library
@jbevain
Copy link
Owner

jbevain commented Apr 6, 2020

Hey!

Thanks for your contribution! Unfortunately I don't think I'll take this one, I'm not sure I want to add that to the public API and support it and have people take a dependency on Cecil for that feature.

It should be very easy to take the code needed out and extract that into a separate project.

Thanks again!

@jbevain jbevain closed this Apr 6, 2020
@jetersen jetersen deleted the fix/StrongKeyPair branch April 6, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants