Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect time information for completed game #75

Closed
jbkuczma opened this issue May 8, 2018 · 1 comment
Closed

Incorrect time information for completed game #75

jbkuczma opened this issue May 8, 2018 · 1 comment
Labels
bug good first issue
Milestone
v2.4

Comments

@jbkuczma
Copy link
Owner

jbkuczma commented May 8, 2018 •
edited
Loading

76ers - Celtics game is complete but shows "Tip Off" rather than "Final"

img_a35d5b9c1c36-1
@jbkuczma jbkuczma added this to the v2.4 milestone May 8, 2018
@jbkuczma
Copy link
Owner Author

jbkuczma commented May 8, 2018 •
edited
Loading

Problem is here. The property that is determining if a game is complete in the code is endTimeUTC which doesn't seem to be returned if other games are going on (if all games are complete then it is returned). There is also a boolean property isGameActivated that always seems to be returned.

jbkuczma added a commit that referenced this issue May 27, 2018
@jbkuczma
for #75 add statusNum check to game status renderer
519d0e5
@jbkuczma jbkuczma mentioned this issue May 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@jbkuczma