Force java 8 for compilation #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 14, 2016 11:34
|
Hi, That's normal that's you change the organization setting? |
|
It wasnt merged. Im just maintaining my own fork at this point. I changed it because I didnt want it to look like it was coming from lightbend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will be relevant for a broader audience, but I've noticed when compiling this in a docker container it was ignoring java home. This will force it to lookup java home from the environment variables when compiling. Maybe you have suggestions that are more suitable for the broader scala audience? Happy to update.
See:
http://stackoverflow.com/questions/27461385/invalid-source-release-1-8-on-jenkins-in-sbt
and the reason for SBT upgrade:
sbt/sbt#2256