Java 9 and modules related changes #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec, update file accordingly
dmlloyd
force-pushed
the
java9-and-modules
branch
from
af1c921 to
89fc91a
Compare
jamezp
reviewed
Dec 5, 2017
| @@ -0,0 +1,101 @@ | |||
| package org.jboss.logmanager; | |||
There was a problem hiding this comment.
Do we want a copyright header on this?
There was a problem hiding this comment.
I saw it was missing, but after certain recent internal discussions my opinion was pretty much ¯\_(ツ)_/¯
There was a problem hiding this comment.
Yeah same. I added it only for consistency.
…d calling module check facilities
…n be overridden for Java 9
jamezp
force-pushed
the
java9-and-modules
branch
from
89fc91a to
d1ac66f
Compare
jamezp
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.