[LOGMGR-177] Add a new DelayedHandler which will queue messages until… #164
Conversation
| private final Deque<ExtLogRecord> logRecords = new ArrayDeque<>(); | ||
|
|
||
| private volatile boolean activated = false; | ||
| private volatile int callerCalculationState = -1; |
There was a problem hiding this comment.
This could just be a volatile boolean forceCallerCalculation...
There was a problem hiding this comment.
I thought about that, but then you wouldn't know if it was explicitly set to false. If explicitly set I want to avoid the super invocation.
| * @param value {@code false} to explicitly disable the caller information otherwise {@code false} to always | ||
| * ensure the caller information is recorded | ||
| */ | ||
| public void setCallerCalculationRequired(final boolean value) { |
| } | ||
| // It's possible being a delayed handler that this could report a false negative. However since the this can | ||
| // manually be overridden it's best to assume we don't want the caller information. | ||
| return super.isCallerCalculationRequired(); |
There was a problem hiding this comment.
Change this whole method to:
return forceCallerCalculation || super.isCallerCalculationRequired();
There was a problem hiding this comment.
IOW we never want to force not calculating the caller, but we also don't want to calculate the caller unless we must.
There was a problem hiding this comment.
Okay fair point. I guess that really does make more sense in a case where the formatter may really want the caller information, but the user made a mistake of setting it to false.
jamezp
force-pushed
the
LOGMGR-177-delayed-handler-delegate
branch
from
db20976 to
eebd7b8
Compare
… at least one child handler is set.
jamezp
force-pushed
the
LOGMGR-177-delayed-handler-delegate
branch
from
eebd7b8 to
11e2ec1
Compare
… at least one child handler is set.
https://issues.jboss.org/browse/LOGMGR-177
Simply adds a
DelayedHandlerwhich will queue messages until a child handler is added. Once added the queue is drained and any log messages published after activation will be directly published to child handlers.