CLOUD-3228 openshift.KUBE_PING doesn't work on OCP 4.1 since it only … #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parses the first CA certificate from the ca.crt store
luck3y
approved these changes
May 21, 2019
|
@errantepiphany Can you take a look at this? This is required for OS 4.1 openshift.KUBE_PING to work. If it looks ok to you, how many beers do I need to buy you to get you to do a release? :) |
|
@luck3y Hi Ken. It looks good to me. It doesn't look like there is a test for it, though. But... I don't think there was a test for it to begin with. Have you been able to manually test successfully? |
|
@errantepiphany Yeah, I built a test image and tested that (QE is testing with it too.) @rhusar did his own testing as well. |
|
@luck3y Okay I'll merge, tag, and create a new brew build for you. Is there anything else I should wait for? Or is it just this one change? |
errantepiphany
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…parses the first CA certificate from the ca.crt store
Jira
https://issues.jboss.org/browse/CLOUD-3228