Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3.14.SP] [JBEAP-26020] Do not override application-specified com.sun.faces.enableDistributable value #97

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

sudeshnas93
Copy link

Issue: https://issues.redhat.com/browse/JBEAP-26020

Mojarra defines a number of initialization parameters. While "com.sun.faces.enableDistributable" is one of them, Mojarra automatically overrides any existing setting provided by the application.
If a web application wanted explicitly disable this for a distributable web application, it would normally add a servlet context parameter within web.xml.
e.g.

<web-app>
  <distributable/>
  <context-param>
    <param-name>com.sun.faces.enableDistributable</param-name>
    <param-value>false</param-value>
  </context-param>
</web-app>

However, the ConfigureListener auto-enables the com.sun.faces.enableDistributable configuration property whenever it see that the tag in web.xml, overriding any custom setting.
I would expect Mojarra to respect the setting defined by the application, and only provide a default value if no value was specified.

@lvydra
Copy link

lvydra commented Dec 11, 2023

Hi @jasondlee, eclipse-ee4j/mojarra#5363 should be merged now.

@jasondlee jasondlee merged commit 2443075 into jboss:2.3.14.SP Dec 11, 2023
@jasondlee
Copy link

Looks good. Thanks @sudeshnas93, @lvydra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants