Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server-side out of order ajax responses #418

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

dmorehouse
Copy link

@dmorehouse dmorehouse commented Apr 19, 2023

With server-side rendering if multiple concurrent ajax requests return out of order, a previous ajax response could end up overwriting (on the client side) a later response. Ajax datatables has a builtin solution for this. It passes a draw parameter which serves as a version (it's just a counter). If an ajax response is from a version prior to what is currently being displayed, then the result is ignored. The draw parameter is expected to be returned (casted as an integer to prevent XSS attacks) as specified by Ajax datatables here - https://datatables.net/manual/server-side#Returned-data

This PR will offer an immediate fix for out of order response rendering for all default configurations of ajax-datatables-rails.

@n-rodriguez n-rodriguez merged commit b541799 into jbox-web:master Apr 19, 2023
@n-rodriguez
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants