Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for trilogy adapter for MySQL #422 #423

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

mrudult
Copy link
Contributor

@mrudult mrudult commented Feb 8, 2024

Adds support for trilogy adapter in Rails >= 6 and <= 7.0.

Rails 7.1 includes trilogy as a built-in adapter and makes it default in Rails 8 - rails/rails#47880, https://rubyonrails.org/2023/10/5/Rails-7-1-0-has-been-released

Copy link
Collaborator

@antillas21 antillas21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n-rodriguez n-rodriguez self-requested a review February 8, 2024 17:05
@mrudult mrudult requested a review from antillas21 February 8, 2024 18:33
@mrudult
Copy link
Contributor Author

mrudult commented Feb 8, 2024

It looks like making trilogy default (and built-in in Rails 7.1) is pushed back as it doesn't yet support caching_sha2_password password auth. Thus, adding back the dependency to rails 7.1 gemfile.

@naoyanickf
Copy link

plz merge this...this is very important

@n-rodriguez n-rodriguez merged commit 50128ec into jbox-web:master Apr 8, 2024
1 check passed
@naoyanickf
Copy link

@n-rodriguez thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants