Actually check for pct

[IndrekHaav]

I noticed that _set_version() claims to check for pct first, but actually checks for lxc (which fails on Proxmox, and therefore the plugin settles on LXC v1). Running a playbook with -vvv confirms that lxc-attach and similar commands are used, instead of the Proxmox pct command.

I'm guessing it's just a typo; in any case this PR should fix it.

[jbrubake]

Thanks. Definitely a typo which then made me wonder why the plugin was actually working. It turns out it was finding LXC v1 (lxc-info) and just using that. So I'm not sure this plugin is even that useful as long as the upstream ansible-lxc-ssh keep supporting LXC v1.

Maybe if I take advantage of specific pct functionality it would be useful?

[IndrekHaav]

For executing commands inside a container, I don't think there is much difference between pct exec and lxc-attach - the former is essentially just a wrapper for the latter.

There are some pct commands that might be useful for Ansible tasks, like lxc push/pull for moving files to/from the container, that don't have direct lxc-* equivalents, but I don't know if those can be implemented in a connection plugin.

[jbrubake]

I just pushed a quick fix that allows a non-root user to use this plugin. That alone seems reason enough to keep this fork alive so I'll keep working on it as I'm able