Reverting PR 42545 (for now) (elastic#44277)

.sass-lint.yml

@@ -7,29 +7,32 @@ files:
     - 'x-pack/legacy/plugins/rollup/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
-  ignore:
-    - 'x-pack/legacy/plugins/canvas/external_runtime/**/*.s+(a|c)ss'
 rules:
   quotes:
     - 2
-    - style: 'single'
+    -
+      style: 'single'
   # } else { style on one line, like our JS
   brace-style:
     - 2
-    - style: '1tbs'
+    -
+      style: '1tbs'
   variable-name-format:
     - 2
-    - convention: 'camelcase'
+    -
+      convention: 'camelcase'
   # Needs regex, right now we ignore
   class-name-format: 0
   # Order how you please
   property-sort-order: 0
   hex-notation:
     - 2
-    - style: 'uppercase'
+    -
+      style: 'uppercase'
   mixin-name-format:
     - 2
-    - allow-leading-underscore: false
+    -
+      allow-leading-underscore: false
       convention: 'camelcase'
   # Use none instead of 0 for no border
   border-zero:
@@ -44,7 +47,8 @@ rules:
   indentation: 2
   function-name-format:
     - 2
-    - allow-leading-underscore: false
+    -
+      allow-leading-underscore: false
       convention: 'camelcase'
   # This removes the need for ::hover
   pseudo-element: 0
@@ -58,20 +62,23 @@ rules:
   force-attribute-nesting: 0
   no-qualifying-elements:
     - 2
-    - # Allows input[type=search]
+    -
+      # Allows input[type=search]
       allow-element-with-attribute: 1
   # Files can end without a newline
   final-newline: 0
   # We use some rare duplicate property values for browser variance
   no-duplicate-properties:
     - 2
-    - exclude:
+    -
+      exclude:
         - 'font-size'
         - 'word-break'
   # Put a line-break between sections of CSS, but allow quicky one-liners for legibility
   empty-line-between-blocks:
     - 2
-    - allow-single-line-rulesets: 1
+    -
+      allow-single-line-rulesets: 1
   # Warns are nice for deprecations and development
   no-warn: 0
   # Transition all is useful in certain situations and there's no recent info to suggest slowdown

package.json

@@ -418,7 +418,6 @@
     "nock": "10.0.6",
     "node-sass": "^4.9.4",
     "normalize-path": "^3.0.0",
-    "null-loader": "^3.0.0",
     "nyc": "^14.1.1",
     "pixelmatch": "4.0.2",
     "pkg-up": "^2.0.0",

renovate.json5

@@ -577,14 +577,6 @@
           '@types/zen-observable',
         ],
       },
-      {
-        groupSlug: 'archiver',
-        groupName: 'archiver related packages',
-        packageNames: [
-          'archiver',
-          '@types/archiver',
-        ],
-      },
       {
         groupSlug: 'base64-js',
         groupName: 'base64-js related packages',

x-pack/legacy/plugins/canvas/.storybook/storyshots.test.js

@@ -53,14 +53,6 @@ jest.mock(
   }
 );
 
-// Disabling this test due to https://github.com/elastic/eui/issues/2242
-jest.mock(
-  '../public/components/workpad_header/workpad_export/flyout/__examples__/external_embed_flyout.examples',
-  () => {
-    return 'Disabled Panel';
-  }
-);
-
 addSerializer(styleSheetSerializer);
 
 // Initialize Storyshots and build the Jest Snapshots

x-pack/legacy/plugins/canvas/__tests__/fixtures/workpads.ts

@@ -6,16 +6,6 @@
 import { CanvasWorkpad, CanvasElement, CanvasPage } from '../../types';
 
 const BaseWorkpad: CanvasWorkpad = {
-  '@created': '2019-02-08T18:35:23.029Z',
-  '@timestamp': '2019-02-08T18:35:23.029Z',
-  assets: {
-    'asset-ada763f1-295e-4188-8e08-b5bed9e006a1': {
-      id: 'asset-ada763f1-295e-4188-8e08-b5bed9e006a1',
-      '@created': '2018-01-17T19:13:09.185Z',
-      type: 'dataurl',
-      value: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4=',
-    },
-  },
   name: 'base workpad',
   id: 'base-workpad',
   width: 0,

x-pack/legacy/plugins/canvas/common/lib/constants.ts

@@ -4,8 +4,6 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { RUNTIME_NAME } from '../../external_runtime/constants';
-
 export const CANVAS_TYPE = 'canvas-workpad';
 export const CUSTOM_ELEMENT_TYPE = 'canvas-element';
 export const CANVAS_APP = 'canvas';
@@ -35,7 +33,3 @@ export const CANVAS_LAYOUT_STAGE_CONTENT_SELECTOR = `canvasLayout__stageContent`
 export const DATATABLE_COLUMN_TYPES = ['string', 'number', 'null', 'boolean', 'date'];
 export const LAUNCHED_FULLSCREEN = 'workpad-full-screen-launch';
 export const LAUNCHED_FULLSCREEN_AUTOPLAY = 'workpad-full-screen-launch-with-autoplay';
-export const API_ROUTE_SNAPSHOT_BASE = '/public/canvas';
-export const API_ROUTE_SNAPSHOT_ZIP = `${API_ROUTE_SNAPSHOT_BASE}/zip`;
-export const API_ROUTE_SNAPSHOT_RUNTIME = `${API_ROUTE_SNAPSHOT_BASE}/runtime`;
-export const API_ROUTE_SNAPSHOT_RUNTIME_DOWNLOAD = `${API_ROUTE_SNAPSHOT_BASE}/${RUNTIME_NAME}.js`;

x-pack/legacy/plugins/canvas/common/lib/fetch.ts → x-pack/legacy/plugins/canvas/common/lib/fetch.js

@@ -15,13 +15,3 @@ export const fetch = axios.create({
   },
   timeout: FETCH_TIMEOUT,
 });
-
-export const arrayBufferFetch = axios.create({
-  responseType: 'arraybuffer',
-  headers: {
-    Accept: 'application/json',
-    'Content-Type': 'application/json',
-    'kbn-xsrf': 'professionally-crafted-string-of-text',
-  },
-  timeout: FETCH_TIMEOUT,
-});