Changes in operation ids (Azure#14665)

* manual changes for swagger * changes for long-running operations * changes for validate for backup and restore * removing 204 from operationResults * changes for a monitoring * adding format * removing date-time from duration * changing to readonly * changes for listRPs * fixes swagger * reverting readonly for scheduleTimes * fixes for checkgates * prettier fixes * cahnges for friendlyname checks * fixing gates * removing tracking-via * model validation fixes * powershell changes * adding stable version * changes for PatchResourceRequestInput * change for req fields * changes for description * changes * Updated swagger json for item level restore target info objects * Fixed spelling errors * Added missing required properties * removed auth credentials property * prettier fixes * Prettier fix * pr comments fixes * fixing readme * changes for go readme * Removed x-ms-flatten property (#2) * removed flatten prop * removing x-ms-flatten * removing friendlyName from req prop Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> * changes in operation ids (#3) * changes in operation ids * changes * changes Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> * lint and model vaidations * changes for prettier * changing version in example Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: FAREAST\zakinkh <zakinkh@microsoft.com>
jbuls · Jun 8, 2021 · 6a4ecab · 6a4ecab
1 parent ee73dbe
commit 6a4ecab
Show file tree

Hide file tree

Showing 6 changed files with 856 additions and 40 deletions.
diff --git a/.../resource-manager/Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json b/.../resource-manager/Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json
@@ -24,7 +24,7 @@
           "BackupVaults"
         ],
         "description": "Returns resource collection belonging to a subscription.",
-        "operationId": "BackupVaults_GetResourcesInSubscription",
+        "operationId": "BackupVaults_GetInSubscription",
         "produces": [
           "application/json"
         ],
@@ -136,7 +136,7 @@
           "OperationStatus"
         ],
         "summary": "Gets the operation status for a resource.",
-        "operationId": "GetOperationStatus",
+        "operationId": "OperationStatus_Get",
         "produces": [
           "application/json"
         ],
@@ -187,7 +187,7 @@
           "BackupVaults"
         ],
         "description": "Returns resource collection belonging to a resource group.",
-        "operationId": "BackupVaults_GetResourcesInResourceGroup",
+        "operationId": "BackupVaults_GetInResourceGroup",
         "produces": [
           "application/json"
         ],
@@ -389,7 +389,7 @@
           "BackupVaults"
         ],
         "description": "Updates a BackupVault resource belonging to a resource group. For example, updating tags for a resource.",
-        "operationId": "BackupVaults_Patch",
+        "operationId": "BackupVaults_Update",
         "produces": [
           "application/json"
         ],
@@ -446,7 +446,7 @@
         "tags": [
           "Resources"
         ],
-        "operationId": "GetOperationResultPatch",
+        "operationId": "BackupVaultOperationResults_Get",
         "produces": [
           "application/json"
         ],
@@ -555,7 +555,7 @@
           "DppFeatureSupport"
         ],
         "summary": "Validates if a feature is supported",
-        "operationId": "CheckFeatureSupport",
+        "operationId": "DataProtection_CheckFeatureSupport",
         "produces": [
           "application/json"
         ],
@@ -609,7 +609,7 @@
           "Operations"
         ],
         "description": "Returns the list of available operations.",
-        "operationId": "Operations_List",
+        "operationId": "DataProtectionOperations_List",
         "parameters": [
           {
             "$ref": "#/parameters/ApiVersion"
@@ -632,6 +632,11 @@
         "x-ms-pageable": {
           "nextLinkName": "nextLink",
           "itemName": "value"
+        },
+        "x-ms-examples": {
+          "Returns the list of supported REST operations.": {
+            "$ref": "./examples/Operations/List.json"
+          }
         }
       }
     },
@@ -758,6 +763,7 @@
           },
           {
             "name": "backupPolicyName",
+            "description": "Name of the policy",
             "in": "path",
             "required": true,
             "type": "string"
@@ -1236,7 +1242,7 @@
           "RecoveryPoint"
         ],
         "description": "Returns a list of Recovery Points for a DataSource in a vault.",
-        "operationId": "RecoveryPoints_GetList",
+        "operationId": "RecoveryPoints_List",
         "produces": [
           "application/json"
         ],
@@ -1306,7 +1312,7 @@
           "RecoveryPoint"
         ],
         "description": "Gets a Recovery Point using recoveryPointId for a Datasource.",
-        "operationId": "RecoveryPoint_Get",
+        "operationId": "RecoveryPoints_Get",
         "produces": [
           "application/json"
         ],
@@ -1870,7 +1876,7 @@
           "BackupInstances"
         ],
         "description": "Validates if Restore can be triggered for a DataSource",
-        "operationId": "BackupInstances_ValidateRestore",
+        "operationId": "BackupInstances_ValidateForRestore",
         "produces": [
           "application/json"
         ],
@@ -1992,12 +1998,12 @@
         }
       }
     },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/backupVaults/{vaultName}/backupInstances/{backupInstances}/findRestorableTimeRanges": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/backupVaults/{vaultName}/backupInstances/{backupInstanceName}/findRestorableTimeRanges": {
       "post": {
         "tags": [
           "FindRestorableTimeRanges"
         ],
-        "operationId": "FindRestorableTimeRanges_Post",
+        "operationId": "RestorableTimeRanges_Find",
         "produces": [
           "application/json"
         ],
@@ -2015,7 +2021,8 @@
             "$ref": "#/parameters/SubscriptionId"
           },
           {
-            "name": "backupInstances",
+            "name": "backupInstanceName",
+            "description": "The name of the backup instance",
             "in": "path",
             "required": true,
             "type": "string"
@@ -2057,7 +2064,7 @@
           "AzureBackupJob"
         ],
         "description": "Gets a job with id in a backup vault",
-        "operationId": "Job_Get",
+        "operationId": "Jobs_Get",
         "produces": [
           "application/json"
         ],
@@ -2367,9 +2374,7 @@
     "AzureBackupFindRestorableTimeRangesRequest": {
       "description": "List Restore Ranges Request",
       "required": [
-        "sourceDataStoreType",
-        "startTime",
-        "endTime"
+        "sourceDataStoreType"
       ],
       "type": "object",
       "properties": {
@@ -2387,11 +2392,11 @@
           }
         },
         "startTime": {
-          "description": "Start time for the List Restore Ranges request",
+          "description": "Start time for the List Restore Ranges request. ISO 8601 format.",
           "type": "string"
         },
         "endTime": {
-          "description": "End time for the List Restore Ranges request",
+          "description": "End time for the List Restore Ranges request. ISO 8601 format.",
           "type": "string"
         }
       }

diff --git a/...review/2021-02-01-preview/examples/BackupInstanceOperations/FindRestorableTimeRanges.json b/...review/2021-02-01-preview/examples/BackupInstanceOperations/FindRestorableTimeRanges.json
@@ -3,7 +3,7 @@
     "subscriptionId": "04cf684a-d41f-4550-9f70-7708a3a2283b",
     "resourceGroupName": "Blob-Backup",
     "vaultName": "ZBlobBackupVaultBVTD3",
-    "backupInstances": "zblobbackuptestsa58",
+    "backupInstanceName": "zblobbackuptestsa58",
     "api-version": "2021-02-01-preview",
     "parameters": {
       "sourceDataStoreType": "OperationalStore",