Add --include-internal flag
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2021
|
Tested on open-telemetry/opentelemetry-go#2280. Works as expected (though for that PR to be mergeable |
jcchavezs
reviewed
Oct 7, 2021
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
jcchavezs
reviewed
Oct 7, 2021
jcchavezs
reviewed
Oct 7, 2021
|
It looks good to me, I just added a comment about semantics but functionality wise it looks good. Thanks! |
mx-psi
force-pushed
the
mx-psi/internal-vanity-imports
branch
from
fbcbb70 to
fe85123
Compare
|
@jcchavezs thanks for the review! Mind taking another look? |
jcchavezs
approved these changes
Oct 8, 2021
|
Thanks @mx-psi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--include-internalflag to includeinternalfolders.